Am 01.04.2022 um 12:08 hat Vladimir Sementsov-Ogievskiy geschrieben: > We have too much logic to simply check that bitmaps are of the same > size. Let's just define that hbitmap_merge() and > bdrv_dirty_bitmap_merge_internal() require their argument bitmaps be of > same size, this simplifies things. > > Let's look through the callers: > > For backup_init_bcs_bitmap() we already assert that merge can't fail. > > In bdrv_reclaim_dirty_bitmap_locked() we gracefully handle the error > that can't happen: successor always has same size as its parent, drop > this logic. > > In bdrv_merge_dirty_bitmap() we already has assertion and separate > check. Make the check explicit and improve error message. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@openvz.org> > Reviewed-by: Nikita Lapshin <nikita.laps...@virtuozzo.com>
Reviewed-by: Kevin Wolf <kw...@redhat.com>
