On Tue, May 03, 2022 at 10:54:41AM +0200, Jason A. Donenfeld wrote: > On Mon, May 02, 2022 at 04:57:43PM -0700, Richard Henderson wrote: > > On 5/2/22 15:52, Jason A. Donenfeld wrote: > > > OpenRISC defines various nop instructions in or1k as meaning shutdown or > > > reset. Implement these in TCG. This has been tested with Linux and > > > confirmed to work. > > > > No, OpenRISC does not define various nop instructions, etc. > > > > OpenRISC defines a Power Management Register to handle doze and suspend; > > there is no > > specification for shutdown or reset. > > > > See https://openrisc.io/architecture > > > Stafford is in the process of documenting/spec'ing the nop stuff.
Hi Richard, Yes, we had a mail discussion about this with Peter. This being similar to ARM semihosting; enabling these special instructions should be behind the semihosting flag. Something that needs to be done for this patch. If you have concern about this let me now. Mail: - https://www.mail-archive.com/qemu-devel@nongnu.org/msg884560.html Our other simulators implement this, so the compromise is if we document this officially and only implement it behind semihosting peter was OK with it. I haven't started on the documentation yet as I haven't has much time in the last few days though. Or1ksim: - https://github.com/openrisc/or1ksim/blob/79c6f153390127e50259d46a7cc0421aa787d2ed/cpu/or32/insnset.c#L768 sim: - https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=sim/or1k/or1k.c;h=bfab35461bee1457fe8f42179ac6d27f5ad46b96;hb=HEAD -Stafford
