Re: [PATCH v2 11/21] target/ppc: Remove msr_gs macro

[Richard Henderson]

On 5/2/22 07:39, Víctor Colombo wrote:

-        ((value >> MSR_GS) & 1) != msr_gs) {
+        !(value & env->msr & R_MSR_GS_MASK)) {

This isn't right.  I think you wanted

  (value ^ env->msr) & R_MSR_GS_MASK


r~