Am 29/04/2022 um 00:19 schrieb Paolo Bonzini: > On 4/28/22 15:46, Stefan Hajnoczi wrote: >>> if have_block >>> util_ss.add(files('aiocb.c', 'async.c', 'aio-wait.c')) >>> + util_ss.add(files('../block/graph-lock.c')) >> Why is it in block/ if it needs to be built into libqemuutil? > Maybe register_aiocontext, unregister_aiocontext and > aio_context_list_lock can be placed in util/async.c? > Yes the above functions are added in util/async.c. It's the best way to automatically add an AioContext when it is created and destroyed. Not really sure where to put it honestly, it's a block layer graph lock so it made sense putting it in block/ but it is not reachable from async. Should I put graph-lock.c in util/? But then won't block/meson.build need it anyways to use it in block/? Emanuele
- [RFC PATCH v2 1/8] aio_wait_kick: add missing m... Emanuele Giuseppe Esposito
- Re: [RFC PATCH v2 1/8] aio_wait_kick: add ... Stefan Hajnoczi
- Re: [RFC PATCH v2 1/8] aio_wait_kick: ... Emanuele Giuseppe Esposito
- Re: [RFC PATCH v2 1/8] aio_wait_ki... Stefan Hajnoczi
- Re: [RFC PATCH v2 1/8] aio_wait_kick: add ... Paolo Bonzini
- [RFC PATCH v2 6/8] block: assert that graph rea... Emanuele Giuseppe Esposito
- Re: [RFC PATCH v2 6/8] block: assert that ... Stefan Hajnoczi
- [RFC PATCH v2 4/8] async: register/unregister a... Emanuele Giuseppe Esposito
- Re: [RFC PATCH v2 4/8] async: register/unr... Stefan Hajnoczi
- Re: [RFC PATCH v2 4/8] async: register... Paolo Bonzini
- Re: [RFC PATCH v2 4/8] async: regi... Emanuele Giuseppe Esposito
- [RFC PATCH v2 3/8] block: introduce a lock to p... Emanuele Giuseppe Esposito
- Re: [RFC PATCH v2 3/8] block: introduce a ... Paolo Bonzini
- Re: [RFC PATCH v2 3/8] block: introduce a ... Stefan Hajnoczi
- Re: [RFC PATCH v2 3/8] block: introduc... Emanuele Giuseppe Esposito
- Re: [RFC PATCH v2 3/8] block: intr... Stefan Hajnoczi
- Re: [RFC PATCH v2 3/8] block: ... Emanuele Giuseppe Esposito
- Re: [RFC PATCH v2 3/8] bl... Stefan Hajnoczi
- [RFC PATCH v2 5/8] block.c: wrlock in bdrv_repl... Emanuele Giuseppe Esposito
- Re: [RFC PATCH v2 5/8] block.c: wrlock in ... Paolo Bonzini
- Re: [RFC PATCH v2 5/8] block.c: wrlock in ... Stefan Hajnoczi