On Thu, Apr 28, 2022 at 01:16:51PM +0200, Jason A. Donenfeld wrote: > Hey again, > > On Thu, Apr 28, 2022 at 02:04:29AM +0200, Jason A. Donenfeld wrote: > > By the way, would this also help the reboot case? That's > > `reboot(RB_AUTOBOOT);`, which does: > > > > machine_restart() -> > > do_kernel_restart() -> > > atomic_notifier_chain_register(&restart_handler_list, nb) -> > > ??? > > > > As far as I can tell, nothing is wired into the reboot case for > > OpenRISC. Is this something that could be fixed in the kernel without > > having to patch QEMU? If so, then I could effectively get shutdown for > > my CI with the -no-reboot option, which is what I'm already doing for a > > few platforms. > > I added 13 for this: > https://lists.librecores.org/pipermail/openrisc/2022-April/003884.html > > When you go add these nops to the specification, please remember to add > one for reboot too. Then, once that kernel code is merged and the > specification published, it'll be sensible to add shutdown and reboot > support to QEMU, per Peter's description.
This sounds fair. -Stafford