On Sat, Apr 16, 2022 at 07:03:57PM +0000, Lukas Straub wrote: > On Thu, 14 Apr 2022 19:57:47 +0200 > Paolo Bonzini <pbonz...@redhat.com> wrote: > > > The main point of this series is patch 7, which removes the dubious and > > probably wrong use of atomics in block/nbd.c. This in turn is enabled > > mostly by the cleanups in patches 3-5. Together, they introduce a > > QemuMutex that synchronizes the NBD client coroutines, the reconnect_delay > > timer and nbd_cancel_in_flight() as well. > > > > The fixes happen to remove an incorrect use of qemu_co_queue_restart_all > > and qemu_co_enter_next on the s->free_sema CoQueue, which was not guarded > > by s->send_mutex. > > > > The rest is bugfixes, simplifying the code a bit, and extra documentation.
> For the whole series: > > Reviewed-by: Lukas Straub <lukasstra...@web.de> I've queued the series through my NBD tree for a pull request in the next week. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
