On 4/13/22 17:55, Eric Blake wrote:
- g_assert(qemu_in_coroutine());
Why is this assert dropped? Is it because we've marked the function
with coroutine_fn? If so, should we drop it earlier in the series,
when you added the label?
The label doesn't guarantee much, but in this case it's pretty clear-cut
that we must be in a coroutine, the code just doesn't make sense otherwise.
We're also about to take a CoMutex (and before the patch we had already
taken it) so if anywhere the place for the assertion would be
qemu_co_mutex_lock().
Otherwise, the patch makes sense to me.
