17.03.2022 00:28, Eric Blake wrote:
+++ b/qapi/block-export.json
@@ -6,6 +6,7 @@
##
{ 'include': 'sockets.json' }
+{ 'include': 'block-core.json' }
Hmm. Does this extra inclusion negatively impact qemu-storage-daemon,
since that is why we created block-export.json in the first place (to
minimize the stuff that qsd pulled in without needing all of
block-core.json)? In other words, would it be better to move
BlockDirtyBitmapOrStr to this file?
Actually, looking at storage-daemon/qapi/qapi-schema.json I see
block-cores.json.
That's block.json which is not mentioned in
storage-daemon/qapi/qapi-schema.json.
So, I think it's OK to keep simple include for now.
--
Best regards,
Vladimir
