Am 04.04.2022 um 11:41 hat Paolo Bonzini geschrieben: > As an aside, instead of is_external, QEMU could remove/add the ioeventfd > handler in the blk->dev_ops->drained_begin and blk->dev_ops->drained_end > callbacks respectively. But that's just a code cleanup.
Yes, this is the proper way to do it that we intended to implement "sometime later". aio_disable_external() is really an ugly hack. I assume that with multiqueue, we'll have to rework this anyway because there won't be a single AioContext to disable any more - and I'm not sure if a node will even know from which AioContexts requests could potentially be sent to it. So we may have to go through the proper callback mechanisms at that point. Kevin