On Fri, Apr 1, 2022 at 2:17 AM Eugenio Pérez <epere...@redhat.com> wrote: > > It always returns IOVA_OK so nobody uses it. > > Signed-off-by: Eugenio Pérez <epere...@redhat.com>
Acked-by: Jason Wang <jasow...@redhat.com> > --- > include/qemu/iova-tree.h | 4 +--- > util/iova-tree.c | 4 +--- > 2 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/include/qemu/iova-tree.h b/include/qemu/iova-tree.h > index c938fb0793..16bbfdf5f8 100644 > --- a/include/qemu/iova-tree.h > +++ b/include/qemu/iova-tree.h > @@ -72,10 +72,8 @@ int iova_tree_insert(IOVATree *tree, const DMAMap *map); > * provided. The range does not need to be exactly what has inserted, > * all the mappings that are included in the provided range will be > * removed from the tree. Here map->translated_addr is meaningless. > - * > - * Return: 0 if succeeded, or <0 if error. > */ > -int iova_tree_remove(IOVATree *tree, const DMAMap *map); > +void iova_tree_remove(IOVATree *tree, const DMAMap *map); > > /** > * iova_tree_find: > diff --git a/util/iova-tree.c b/util/iova-tree.c > index 6dff29c1f6..fee530a579 100644 > --- a/util/iova-tree.c > +++ b/util/iova-tree.c > @@ -164,15 +164,13 @@ void iova_tree_foreach(IOVATree *tree, > iova_tree_iterator iterator) > g_tree_foreach(tree->tree, iova_tree_traverse, iterator); > } > > -int iova_tree_remove(IOVATree *tree, const DMAMap *map) > +void iova_tree_remove(IOVATree *tree, const DMAMap *map) > { > const DMAMap *overlap; > > while ((overlap = iova_tree_find(tree, map))) { > g_tree_remove(tree->tree, overlap); > } > - > - return IOVA_OK; > } > > /** > -- > 2.27.0 >