Hi,
> > +void x86_firmware_configure(void *ptr, int size)
> > +{
> > + int ret;
> > +
> > + /*
> > + * OVMF places a GUIDed structures in the flash, so
> > + * search for them
> > + */
> > + pc_system_parse_ovmf_flash(ptr, size);
>
> Any reason you chose to put this outside the sev_enabled()
> check when you moved it, as that is a functional change ?
Well, we probably get a 'if (tdx_enabled())' branch soon, and
pc_system_parse_ovmf_flash() will be needed for both sev and tdx.
> It ought to be harmless in theory, unless someone figures
> out a way to break pc_system_parse_ovmf_flash code with
> unexpected input.
Yes, strictly speaking this is a functional change. Without
sev the pc_system_parse_ovmf_flash() results will be ignored
though, so there should be no change in qemu behavior ...
take care,
Gerd
