On 3/29/22 07:39, Philippe Mathieu-Daudé wrote:
On 28/3/22 22:49, Andreas K. Hüttel wrote:With the command line flag -mplt and a recent toolchain, ELF binaries generated by gcc can obtain EI_ABIVERSION=1, which makes, e.g., gcc three-stage bootstrap in a mips-unknown-linux-gnu qemu-user chroot fail since the binfmt-misc magic does not match anymore. Also other values are technically possible. qemu executes these binaries just fine, so relax the mask for the EI_ABIVERSION byte at offset 0x08.In addition, extend magic string to distinguish mips o32 and n32 ABI. This information is given by the EF_MIPS_ABI2 (0x20) bit in the e_flags field of the ELF header (a 4-byte value at offset 0x24 for the here applicable ELFCLASS32). See-also: ace3d65459 Signed-off-by: Andreas K. Hüttel <dilfri...@gentoo.org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: WANG Xuerui <xe...@gentoo.org>v5 changes are too different from v4 to keep these R-b tags IMO. LGTM but I'd like Xuerui to double-check the R-b stands, and an Acked-by from Laurent would make me feel safer ;)
This is just a squash of v4 patches, but I manually double-checked the definitions against elf.h for that extra confidence, and they looked good. The R-b tags still stand :)
-- WANG Xuerui xe...@gentoo.org Gentoo Linux developer PGP: 7C52 19E3 26A0 7311 3EA3 8806 C01F 7214 BC93 1414
OpenPGP_0xC01F7214BC931414.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
