On 7/3/22 14:49, Akihiko Odaki wrote:
ui/cocoa: Create menus in iothread
Commit 0439c5a4623d674efa0c72abd62ca6e98bb7cf87 introduced an
assertion that blk_all_next is called in the main thread. The function
is called in the following chain:
- blk_all_next
- qmp_query_block
- addRemovableDevicesMenuItems
- main
This change moves the menu creation to the iothread. This also changes
the menu creation procedure to construct the entire menu tree before
setting to NSApp, which is necessary because a menu set once cannot be
modified if NSApp is already running.
v2: Separate a change moving create_initial_menus (Peter Maydell)
Akihiko Odaki (2):
ui/cocoa: Move create_initial_menus
ui/cocoa: Create menus in iothread
Patch #2 doesn't apply anymore, can you respin?
