Hello, I remember this PR. It was a long time ago. I'll take a look at it and propose a fix.
Thanks, Ahmed On Fri, 18 Mar 2022 at 19:25, Thomas Huth <th...@redhat.com> wrote: > On 20/06/2021 19.54, Ahmed Abouzied wrote: > > Replaces TABs with spaces, making sure to have a consistent coding style > > of 4 space indentations in the SH4 subsystem. > > > > Signed-off-by: Ahmed Abouzied <em...@aabouzied.com> > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/376 > > --- > ... > > @@ -1705,101 +1705,101 @@ static void _decode_opc(DisasContext * ctx) > > } > > return; > > case 0xf00d: /* fsts FPUL,FRn - FPSCR: Nothing */ > > - CHECK_FPU_ENABLED > > + CHECK_FPU_ENABLED > > tcg_gen_mov_i32(FREG(B11_8), cpu_fpul); > > - return; > > + return; > > case 0xf01d: /* flds FRm,FPUL - FPSCR: Nothing */ > > - CHECK_FPU_ENABLED > > + CHECK_FPU_ENABLED > > tcg_gen_mov_i32(cpu_fpul, FREG(B11_8)); > > - return; > > + return; > > Sorry, it's a very late reply ... but in case you're still interested in > fixing this: It seems like at least some of these files used TABs as 8 > spaces, not as 4 spaces, so after applying your patch, the indentation > seems > to be wrong in all places. Please double-check the look of the files > before > sending! Thanks! > > Thomas > >
