> Just use a little-endian load: MO_LE | es. > While we use MO_TE all over, it's no secret that it's always big-endian.
> And everywhere else you do load then swap, or swap then store. This is not working as expected... I tried it in two places, both with a swap [removed] after and the tests failed. I'm submitting the split patches with whitespace fixes. I hope it's not a dealbreaker, seeing as it matches the rest of the file this way anyhow. If it is, I will spend some more time looking into it tomorrow. Thanks, - David Miller On Thu, Mar 3, 2022 at 1:04 PM David Hildenbrand <da...@redhat.com> wrote: > On 03.03.22 19:01, David Miller wrote: > > > > Makes sense, thanks for the quick reply. > > Last question, the patches can depend on others in the same set right? > > IE: all of the additions to insn-data.def in one, implementations in > > separate patches. > > For bisectability, each patch should be self-contained and can only > depend on earlier patches in the series. > > See my VX patches to get an idea of how it could look like, e.g., > > > commit e58de341d948d12cb36bbc5aa4866b7412581880 > Author: David Hildenbrand <da...@redhat.com> > Date: Wed Apr 10 22:45:35 2019 +0200 > > s390x/tcg: Implement VECTOR SUM ACROSS WORD > > Similar to VECTOR SUM ACROSS DOUBLEWORD. > > Reviewed-by: Richard Henderson <richard.hender...@linaro.org> > Signed-off-by: David Hildenbrand <da...@redhat.com> > > commit 8dc69a196eb2e3e8ab1d033b378e4f5a5efaa219 > Author: David Hildenbrand <da...@redhat.com> > Date: Wed Apr 10 22:40:01 2019 +0200 > > s390x/tcg: Implement VECTOR SUM ACROSS QUADWORD > > Similar to VECTOR SUM ACROSS DOUBLEWORD, however without a loop and > using 128-bit calculations. > > Reviewed-by: Richard Henderson <richard.hender...@linaro.org> > Signed-off-by: David Hildenbrand <da...@redhat.com> > > commit fe2be36d26b3d3e86246c88bb09a9613b99dc6c9 > Author: David Hildenbrand <da...@redhat.com> > Date: Wed Apr 10 22:48:25 2019 +0200 > > s390x/tcg: Implement VECTOR SUM ACROSS DOUBLEWORD > > Perform the calculations without a helper. Only 16 bit or 32 bit values > have to be added. > > Reviewed-by: Richard Henderson <richard.hender...@linaro.org> > Signed-off-by: David Hildenbrand <da...@redhat.com> > > commit bc725e65152c57d42f19eec134c99940114d6362 > Author: David Hildenbrand <da...@redhat.com> > Date: Tue Apr 9 23:26:47 2019 +0200 > > s390x/tcg: Implement VECTOR SUBTRACT WITH BORROW COMPUTE BORROW > INDICATION > > Mostly courtesy of Richard H. > > Reviewed-by: Richard Henderson <richard.hender...@linaro.org> > Signed-off-by: David Hildenbrand <da...@redhat.com> > > commit 48390a7c2716a128155b872d5316cda5f55dcfa9 > Author: David Hildenbrand <da...@redhat.com> > Date: Wed Apr 10 22:15:07 2019 +0200 > > s390x/tcg: Implement VECTOR SUBTRACT WITH BORROW INDICATION > > Fairly easy as only 128-bit handling is required. Simply perform the > subtraction and then subtract the borrow. > > Reviewed-by: Richard Henderson <richard.hender...@linaro.org> > Signed-off-by: David Hildenbrand <da...@redhat.com> > > > > -- > Thanks, > > David / dhildenb > >
