On Fri, Feb 25, 2022 at 03:59:40PM -0500, John Snow wrote: > Previously, I had a method named "accept()" that under-the-hood calls > bind(2), listen(2) *and* accept(2). I meant this as a simplification and > counterpart to the one-shot "connect()" method. > > This is confusing to readers who expect accept() to mean *just* > accept(2). Since I need to split apart the "accept()" method into > multiple methods anyway (one of which strongly resembling accept(2)), it > feels pertinent to rename this method *now*. > > Rename this all-in-one method "start_server_and_accept()" instead. > > Signed-off-by: John Snow <js...@redhat.com> > --- > python/qemu/aqmp/legacy.py | 2 +- > python/qemu/aqmp/protocol.py | 6 ++++-- > python/tests/protocol.py | 24 ++++++++++++------------ > 3 files changed, 17 insertions(+), 15 deletions(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
