On Fri, Mar 4, 2022 at 7:35 AM Markus Armbruster <arm...@redhat.com> wrote:
>
> Eugenio Pérez <epere...@redhat.com> writes:
>
> > Finally offering the possibility to enable SVQ from the command line.
> >
> > Signed-off-by: Eugenio Pérez <epere...@redhat.com>
> > ---
> > qapi/net.json | 8 +++++++-
> > net/vhost-vdpa.c | 48 ++++++++++++++++++++++++++++++++++++++++--------
> > 2 files changed, 47 insertions(+), 9 deletions(-)
> >
> > diff --git a/qapi/net.json b/qapi/net.json
> > index 7fab2e7cd8..06a74d4224 100644
> > --- a/qapi/net.json
> > +++ b/qapi/net.json
> > @@ -445,12 +445,18 @@
> > # @queues: number of queues to be created for multiqueue vhost-vdpa
> > # (default: 1)
> > #
> > +# @x-svq: Start device with (experimental) shadow virtqueue. (Since 7.0)
> > +#
> > +# Features:
> > +# @unstable: Member @x-svq could change in future revisions.
>
> Elsewhere we document "Member @foo is experimental." Does your
> different phrasing indicate a difference in intent?
>
Not really, I can use "Member @foo is experimental." too. I'll change
for the next revision.
> > +#
> > # Since: 5.1
> > ##
> > { 'struct': 'NetdevVhostVDPAOptions',
> > 'data': {
> > '*vhostdev': 'str',
> > - '*queues': 'int' } }
> > + '*queues': 'int',
> > + '*x-svq': {'type': 'bool', 'features' : [ 'unstable'] } } }
> >
> > ##
> > # @NetClientDriver:
>
> Do you hope to make @x-svq stable eventually? If yes: you'll want to
> rename it to @svq then, which could be a bother. Can be avoided by
> naming it @svq now. Up to you.
>
Yes, I'll rename for the next revision.
Thanks!
> [...]
>
