huang...@chinatelecom.cn writes: > From: Hyman Huang(黄勇) <huang...@chinatelecom.cn> > > query-vcpu-dirty-limit success depends on enabling dirty > page rate limit, so just add it to the list of skipped > command to ensure qmp-cmd-test run successfully. > > Signed-off-by: Hyman Huang(黄勇) <huang...@chinatelecom.cn> > Reported-by: Dr. David Alan Gilbert <dgilb...@redhat.com> > --- > tests/qtest/qmp-cmd-test.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/qtest/qmp-cmd-test.c b/tests/qtest/qmp-cmd-test.c > index 7f103ea..4b216a0 100644 > --- a/tests/qtest/qmp-cmd-test.c > +++ b/tests/qtest/qmp-cmd-test.c > @@ -110,6 +110,8 @@ static bool query_is_ignored(const char *cmd) > "query-sev-capabilities", > "query-sgx", > "query-sgx-capabilities", > + /* Success depends on enabling dirty page rate limit */ > + "query-vcpu-dirty-limit", > NULL > }; > int i;
I think you need to squash this into the patch that adds the command, so "make check" passes after each commit. As far as I can tell, there is no other test coverage. That gap needs to be plugged.
