So, in which route should I go with this? I could add a reference to the ACPI spec, but can write and explain more if you want me to.but I feel quoting spec and including table name is a good idea actually, but pls quote verbatim:I don't do that and don't ask it from others.The reason being that pointing where to look in spec and having verbatim copy of field name is sufficient for looking it up and QEMU does not endup with half of spec copied in (+unintentional mistakes). (As reviewer I will check if whatever written in patch actually matches spec anyways) That's why I typically use 'spec ver, verbatim field name[, chapter/table name]' policy. The later optional part is usually used for pointing to values description.Ok but here the field name was not listed verbatim, and table name is missing. It is actually 8042 and table name is Fixed ACPI Description Table Boot Architecture Flags.
- Re: [PATCH v4 2/3] hw/acpi: add indication... Igor Mammedov
- Re: [PATCH v4 2/3] hw/acpi: add indication... Liav Albani
- Re: [PATCH v4 2/3] hw/acpi: add indica... Ani Sinha
- Re: [PATCH v4 2/3] hw/acpi: add i... Michael S. Tsirkin
- Re: [PATCH v4 2/3] hw/acpi: a... Liav Albani
- Re: [PATCH v4 2/3] hw/acpi: a... Ani Sinha
- Re: [PATCH v4 2/3] hw/acpi: a... Ani Sinha
- Re: [PATCH v4 2/3] hw/acpi: add indication for... Michael S. Tsirkin
- Re: [PATCH v4 2/3] hw/acpi: add indication... Igor Mammedov
- Re: [PATCH v4 2/3] hw/acpi: add indica... Michael S. Tsirkin
- Re: [PATCH v4 2/3] hw/acpi: add i... Liav Albani
- Re: [PATCH v4 2/3] hw/acpi: a... Igor Mammedov
- Re: [PATCH v4 2/3] hw/acpi: add indication... Liav Albani
- Re: [PATCH v4 2/3] hw/acpi: add indica... Ani Sinha
- Re: [PATCH v4 2/3] hw/acpi: add indica... Michael S. Tsirkin
- [PATCH v4 3/3] tests/acpi: i386: update FACP table diff... Liav Albani
- Re: [PATCH v4 3/3] tests/acpi: i386: update FACP t... Ani Sinha
- Re: [PATCH v4 3/3] tests/acpi: i386: update FA... Michael S. Tsirkin
- Re: [PATCH v4 3/3] tests/acpi: i386: updat... Liav Albani
- Re: [PATCH v4 3/3] tests/acpi: i386: u... Ani Sinha
- Re: [PATCH v4 3/3] tests/acpi: i386: u... Michael S. Tsirkin