On 2/15/22 20:53, Vladimir Sementsov-Ogievskiy wrote:
We don't need extra bitmap. All we need is to backup the original bitmap when we do first merge. So, drop extra temporary bitmap and work directly with target and backup. Note that block_dirty_bitmap_merge() semantics changed: on failure target may be modified now, and caller should call block_dirty_bitmap_restore() if needed. The only caller is qmp_transaction() and ->abort() is called for failed action. So, we are OK. Signed-off-by: Vladimir Sementsov-Ogievskiy<vsement...@virtuozzo.com> --- block/monitor/bitmap-qmp-cmds.c | 31 +++++++++---------------------- 1 file changed, 9 insertions(+), 22 deletions(-)
Reviewed-by: Nikita Lapshin<nikita.laps...@virtuozzo.com>