Am 18.11.2011 17:28, schrieb Stefan Hajnoczi: > On Thu, Nov 17, 2011 at 3:13 PM, Kevin Wolf <kw...@redhat.com> wrote: >> - /* FIXME This is too late! */ >> - ret = qcow2_update_snapshot_refcount(bs, s->l1_table_offset, >> s->l1_size, 1); >> + if (ret < 0) { >> + goto fail; >> + } >> + >> + g_free(sn_l1_table); > > Prevent double-free if qcow2_update_snapshot_refcount() fails below: > > sn_l1_table = NULL;
Thanks, good catch. Fixed this locally. Kevin