On 2/8/22 08:38, Eric Auger wrote:
Representing the CRB cmd/response buffer as a standard
RAM region causes some trouble when the device is used
with VFIO. Indeed VFIO attempts to DMA_MAP this region
as usual RAM but this latter does not have a valid page
size alignment causing such an error report:
"vfio_listener_region_add received unaligned region".
To allow VFIO to detect that failing dma mapping
this region is not an issue, let's use a ram_device
memory region type instead.
Signed-off-by: Eric Auger <eric.au...@redhat.com>
Tested-by: Stefan Berger <stef...@linux.ibm.com>
Acked-by: Stefan Berger <stef...@linux.ibm.com>
[PMD: Keep tpm_crb.c in meson's softmmu_ss]
Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
v4 doesn't build for me:
../hw/tpm/tpm_crb.c: In function ?tpm_crb_realize?:
../hw/tpm/tpm_crb.c:297:33: error: implicit declaration of function
?HOST_PAGE_ALIGN? [-Werror=implicit-function-declaration]
297 | HOST_PAGE_ALIGN(CRB_CTRL_CMD_SIZE));
| ^~~~~~~~~~~~~~~
../hw/tpm/tpm_crb.c:297:33: error: nested extern declaration of
?HOST_PAGE_ALIGN? [-Werror=nested-externs]
cc1: all warnings being treated as errors
