On Fri, Jan 28, 2022 at 11:12 AM Daniel P. Berrangé <berra...@redhat.com> wrote: > > This makes the qmp-shell program a little more pleasant to use when you > are just trying to spawn a throw-away QEMU process to query some info > from. > > First it introduces a 'qmp-shell-wrap' command that takes a QEMU command > line instead of QMP socket, and spawns QEMU automatically, so its life > is tied to that of the shell. > > Second it adds ability to log QMP commands/responses to a file that can > be queried with 'jq' to extract information. This is good for commands > which return huge JSON docs. > > In v3: > > - Add qmp-shell-wrap to setup.cfg entry points > > In v2: > > - Unlink unix socket path on exit > - Fix default command name > - Deal with flake8/pylint warnings > > Daniel P. Berrangé (2): > python: introduce qmp-shell-wrap convenience tool > python: support recording QMP session to a file > > python/qemu/aqmp/qmp_shell.py | 88 ++++++++++++++++++++++++++++++++--- > python/setup.cfg | 4 ++ > scripts/qmp/qmp-shell-wrap | 11 +++++ > 3 files changed, 96 insertions(+), 7 deletions(-) > create mode 100755 scripts/qmp/qmp-shell-wrap > > -- > 2.34.1 > >
Great, thanks! I rebased patch 1/2 myself as a courtesy and have staged these. --js (fwiw: using pip, it seems like the wrapper script works just fine. it appears as though using 'python3 setup.py install' does indeed cause issues here. I have a patch I'll send soon that discourages the direct setup.py invocation to avoid frustration in the future.)
