On Sat, 5 Feb 2022 at 17:42, Michael S. Tsirkin <m...@redhat.com> wrote: > > On Sat, Feb 05, 2022 at 01:31:17PM +0000, Peter Maydell wrote: > > On Sat, 5 Feb 2022 at 12:25, Michael S. Tsirkin <m...@redhat.com> wrote: > > > > > > On Sat, Feb 05, 2022 at 11:07:33AM +0000, Peter Maydell wrote: > > > > Fails to compile for 32-bit, Windows and macos because of format > > > > string issues in hmp-cmds.c. Here's a sample job with the errors: > > > > > > > > https://gitlab.com/qemu-project/qemu/-/jobs/2058116754593a84174b0 > > > > > Just re-pushed with a fixup patch. Can you try again pls? > > > > Tag still seems to be pointing at 593a84174b0 ?
> > my bad. pushed a the tag now. Please can you squash fixes into the offending commits rather than adding a fixup patch at the end? Otherwise it breaks bisection. There are also further build failures. On Windows: https://gitlab.com/qemu-project/qemu/-/jobs/2058536550 In file included from ../hw/acpi/erst.c:16: /builds/qemu-project/qemu/include/qemu/osdep.h:76: error: "__USE_MINGW_ANSI_STDIO" redefined [-Werror] 76 | #define __USE_MINGW_ANSI_STDIO 1 | In file included from /usr/i686-w64-mingw32/sys-root/mingw/include/corecrt.h:10, from /usr/i686-w64-mingw32/sys-root/mingw/include/crtdefs.h:10, from /usr/i686-w64-mingw32/sys-root/mingw/include/sys/types.h:13, from ../hw/acpi/erst.c:12: /usr/i686-w64-mingw32/sys-root/mingw/include/_mingw.h:435: note: this is the location of the previous definition 435 | #define __USE_MINGW_ANSI_STDIO 0 /* was not defined so it should be 0 */ | This is because erst.c is incorrectly including other header files before osdep.h. On msys2, some dubious casting: https://gitlab.com/qemu-project/qemu/-/jobs/2058536622 ../hw/virtio/virtio.c: In function 'qmp_x_query_virtio_vhost_queue_status': ../hw/virtio/virtio.c:4358:30: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] 4358 | status->desc = (uint64_t)(unsigned long)hdev->vqs[queue].desc; | ^ ../hw/virtio/virtio.c:4359:31: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] 4359 | status->avail = (uint64_t)(unsigned long)hdev->vqs[queue].avail; | ^ ../hw/virtio/virtio.c:4360:30: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] 4360 | status->used = (uint64_t)(unsigned long)hdev->vqs[queue].used; | ^ cc1.exe: all warnings being treated as errors On the build-tsan and build-cfi-x86_64 jobs and also on macos (this is a "clang is pickier than gcc about unused functions" one): https://gitlab.com/qemu-project/qemu/-/jobs/2058536617 https://gitlab.com/qemu-project/qemu/-/jobs/2058536571 ../tests/qtest/erst-test.c:91:20: error: unused function 'out_reg64' [-Werror,-Wunused-function] static inline void out_reg64(ERSTState *s, unsigned reg, uint64_t v) ^ On build-system-centos, a link failure: https://gitlab.com/qemu-project/qemu/-/jobs/2058536558 libqemu-ppc64-softmmu.fa.p/hw_virtio_virtio.c.o: In function `qmp_decode_features': /builds/qemu-project/qemu/build/../hw/virtio/virtio.c:4155: undefined reference to `gpu_map' /builds/qemu-project/qemu/build/../hw/virtio/virtio.c:4155: undefined reference to `gpu_map' collect2: error: ld returned 1 exit status thanks -- PMM
