On Thu, Jan 27, 2022 at 02:48:57PM +0100, Markus Armbruster wrote: > Alex Bennée <alex.ben...@linaro.org> writes: > > > Victor Toso <victort...@redhat.com> writes: > > > >> Similar to f7160f3218 "schemas: Add vim modeline" > >> > >> Signed-off-by: Victor Toso <victort...@redhat.com> > >> --- > >> qapi/audio.json | 1 + > >> qapi/compat.json | 1 + > >> qapi/replay.json | 1 + > >> qapi/trace.json | 1 + > >> 4 files changed, 4 insertions(+) > >> > >> diff --git a/qapi/audio.json b/qapi/audio.json > >> index 9cba0df8a4..fe3b506ec3 100644 > >> --- a/qapi/audio.json > >> +++ b/qapi/audio.json > >> @@ -1,4 +1,5 @@ > >> # -*- mode: python -*- > >> +# vim: filetype=python > > > > I realise we have Emacs mode annotations here as well and I'm not going > > to start a holy war but I thought we used .editorconfig to avoid messing > > directly with the individual files. So something like: > > > > [*.json] > > indent_style = space > > emacs_mode = python > > vim_filetype = python > > > > should also do the job. > > Most schema files have lines for both Emacs and vim. Some have only the > former, and this patch adds the latter to them. Seems fair to me. > > Perhaps we could get rid of them all instead. As far as I can tell, > .editorconfig doesn't work for stock Emacs out of the box, though.
I think the same is true for vim. You need to enable a plugin for it. Similar to other IDEs. If we have a formal way to suggest that developers install editorconfig plugin for their IDE it would be better than maintaining such annotations. Cheers, Victor
signature.asc
Description: PGP signature
