Hi Francisco, On 16:11 Fri 21 Jan , Francisco Iglesias wrote: > Add a model of Xilinx Versal's OSPI flash memory controller. > > Signed-off-by: Francisco Iglesias <francisco.igles...@xilinx.com> > --- > include/hw/ssi/xlnx-versal-ospi.h | 111 +++ > hw/ssi/xlnx-versal-ospi.c | 1853 > +++++++++++++++++++++++++++++++++++++ > hw/ssi/meson.build | 1 + > 3 files changed, 1965 insertions(+) > create mode 100644 include/hw/ssi/xlnx-versal-ospi.h > create mode 100644 hw/ssi/xlnx-versal-ospi.c > > diff --git a/include/hw/ssi/xlnx-versal-ospi.h > b/include/hw/ssi/xlnx-versal-ospi.h > new file mode 100644 > index 0000000000..14d1263497 > --- /dev/null > +++ b/include/hw/ssi/xlnx-versal-ospi.h > @@ -0,0 +1,111 @@
[snip] > +static void ospi_ahb_decoder_enable_cs(XlnxVersalOspi *s, hwaddr addr) > +{ > + int cs = ospi_ahb_decoder_cs(s, addr); > + > + if (cs >= 0) { > + for (int i = 0; i < s->num_cs; i++) { > + qemu_set_irq(s->cs_lines[i], cs != i); If you re-send a series, indent is off here. Otherwise: Reviewed-by: Luc Michel <l...@lmichel.fr>