Re: [PATCH 3/5] target/ppc: books: Machine Check exception cleanup

[Cédric Le Goater]

On 1/24/22 19:46, Fabiano Rosas wrote:

powerpc_excp_books is BookS only, so remove 40x and BookE code.

Signed-off-by: Fabiano Rosas <faro...@linux.ibm.com>

Reviewed-by: Cédric Le Goater <c...@kaod.org>

Thanks,

C.

---
  target/ppc/excp_helper.c | 17 -----------------
  1 file changed, 17 deletions(-)

diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
index 0d27dfb2c5..e5f09e1984 100644
--- a/target/ppc/excp_helper.c
+++ b/target/ppc/excp_helper.c
@@ -632,23 +632,6 @@ static void powerpc_excp_books(PowerPCCPU *cpu, int excp)
          /* machine check exceptions don't have ME set */
          new_msr &= ~((target_ulong)1 << MSR_ME);

- /* XXX: should also have something loaded in DAR / DSISR */

-        switch (excp_model) {
-        case POWERPC_EXCP_40x:
-            srr0 = SPR_40x_SRR2;
-            srr1 = SPR_40x_SRR3;
-            break;
-        case POWERPC_EXCP_BOOKE:
-            /* FIXME: choose one or the other based on CPU type */
-            srr0 = SPR_BOOKE_MCSRR0;
-            srr1 = SPR_BOOKE_MCSRR1;
-
-            env->spr[SPR_BOOKE_CSRR0] = env->nip;
-            env->spr[SPR_BOOKE_CSRR1] = msr;
-            break;
-        default:
-            break;
-        }
          break;
      case POWERPC_EXCP_DSI:       /* Data storage exception                   
*/
          trace_ppc_excp_dsi(env->spr[SPR_DSISR], env->spr[SPR_DAR]);