MkfsSion <mkfss...@mkfssion.com> writes:
> On 2022/1/19 22:08, Markus Armbruster wrote:
[...]
>> I don't think we should try to make -set work when using JSON arguments.
>>
> Thanks for your detailed review.
You're welcome!
> The following is my opinion towards implementing -set option for JSON
> arguments.
> Having -set option worked for JSON argument improved compatability with
> libvirt (libvirt has switched to use JSON arguments for device by default).
> -set option is useful for libvirt user as libvirt doesn't support all
> functionality that QEMU provides.
I understand you'd like to tweak how libvirt configures things. -set
used to work, but doesn't anymore.
> I have another idea for implementing this feature which seems addressed the
> above issue. We can implement this feature by add new parameter that refers
> to options provided by -set option to qdev_device_add_from_qdict() (This api
> seems is not widely used in QEMU tree) function and use old
> qobject_input_visitor_new() visitor for setting them.
> Do you think is OK to implement this feature in that way?
I'm afraid I don't understand what you're proposing.
Daniel Berrangé suggested to provide the means to tweak in libvirt:
Message-ID: <ydrioc4xbsold...@redhat.com>
https://lists.gnu.org/archive/html/qemu-devel/2022-01/msg00289.html
Would that work for you?
[...]
