On 21/01/2022 11.36, Philippe Mathieu-Daudé wrote:
From: Michael Tokarev <m...@tls.msk.ru>

For a long time, we assumed that libxml2 is necessary for parallels
block format support (block/parallels*). However, this format actually
does not use libxml [*]. Since this is the only user of libxml2 in
whole QEMU tree, we can drop all libxml2 checks and dependencies too.

It is even more: --enable-parallels configure option was the only
option which was silently ignored when it's (fake) dependency
(libxml2) isn't installed.

Drop all mentions of libxml2.

[*] Actually the basis for libxml use were introduced in commit
     ed279a06c53 ("configure: add dependency") but the implementation
     was never merged:
     
https://lore.kernel.org/qemu-devel/70227bbd-a517-70e9-714f-e6e0ec431...@openvz.org/

Signed-off-by: Michael Tokarev <m...@tls.msk.ru>
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
Message-Id: <20220119090423.149315-1-...@msgid.tls.msk.ru>
Tested-by: Philippe Mathieu-Daudé <f4...@amsat.org>
Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>
[PMD: Updated description and adapted to use lcitool]
Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
---
  meson.build                                     | 6 ------
  block/meson.build                               | 3 +--
  meson_options.txt                               | 2 --
  scripts/checkpatch.pl                           | 1 -
  scripts/ci/org.centos/stream/8/x86_64/configure | 1 -
  scripts/coverity-scan/coverity-scan.docker      | 1 -
  scripts/coverity-scan/run-coverity-scan         | 2 +-
  7 files changed, 2 insertions(+), 14 deletions(-)

I think this should touch ./scripts/meson-buildoptions.sh , too?

If you also remove it from that file:

Reviewed-by: Thomas Huth <th...@redhat.com>


Reply via email to