On 14-01-22, 14:06, Alex Bennée wrote: > > Viresh Kumar <viresh.ku...@linaro.org> writes: > > > This creates the QEMU side of the vhost-user-gpio device which connects > > to the remote daemon. It is based of vhost-user-i2c code. > > > > Signed-off-by: Viresh Kumar <viresh.ku...@linaro.org> > <snip> > > +++ b/include/hw/virtio/vhost-user-gpio.h > > @@ -0,0 +1,35 @@ > > +/* > > + * Vhost-user GPIO virtio device > > + * > > + * Copyright (c) 2021 Viresh Kumar <viresh.ku...@linaro.org> > > + * > > + * SPDX-License-Identifier: GPL-2.0-or-later > > + */ > > + > > +#ifndef _QEMU_VHOST_USER_GPIO_H > > +#define _QEMU_VHOST_USER_GPIO_H > > + > > +#include "hw/virtio/virtio.h" > > +#include "hw/virtio/vhost.h" > > +#include "hw/virtio/vhost-user.h" > > +#include "standard-headers/linux/virtio_gpio.h" > > Hmm this fails: > > In file included from ../../hw/virtio/vhost-user-gpio.c:13: > /home/alex/lsrc/qemu.git/include/hw/virtio/vhost-user-gpio.h:15:10: fatal > error: standard-headers/linux/virtio_gpio.h: No such file or directory > 15 | #include "standard-headers/linux/virtio_gpio.h" > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > compilation terminated. > > The usual solution is to create a patch that imports the headers using: > > ./scripts/update-linux-headers.sh > > either from the current mainline (or your own tree if the feature is in > flight) and mark the patch clearly as not for merging.
I have that patch with me and I planned to mention it in the cover-letter, but completely failed while sending it. Should I resend this with the NOT-TO-BE-APPLIED patch now ? Everything is in mainline, so the committer just needs to run scripts/update-linux-headers.sh. -- viresh