On 1/14/22 12:29, Daniel Henrique Barboza wrote:
On 1/14/22 07:46, Cédric Le Goater wrote:
On 1/13/22 20:29, Daniel Henrique Barboza wrote:
One of the remaining dependencies we have on the PnvPhb4PecStack object
is the stack->stack_no property. This is set as the position the stack
occupies in the pec->stacks[] array.
We need a way to report this same value in the PnvPHB4. This patch
creates a new property called 'phb_number' to be used in existing code
in all instances stack->stack_no is currently being used.
The 'phb_number' name is an indication of our future intention to convert
the pec->stacks[] array into a pec->phbs[] array, when the PEC object will
deal directly with phb4 objects.
So the PHB would have a 'phb_number' and a 'index' property ? That's
confusing. Can we simplify ? compute one from another ?
or keep 'stack_no' to make it clear this belongs to the stack subunit
logic.
I guess for now we can keep it as phb->stack_no. We can think about reworking
the
logic (my initial reaction is to keep 'index' and then derive the 'stack_no'
from
it when needed) in a follow up.
ok. Patches 1-10 are fine. no need to resend.
Thanks,
C.
