Daniel P. Berrangé <berra...@redhat.com> writes:
> On Mon, Dec 20, 2021 at 04:44:18PM +0100, Vladimir Sementsov-Ogievskiy wrote:
>> Add command that can change addresses where VNC server listens for new
>> connections. Prior to 6.0 this functionality was available through
>> 'change' qmp command which was deleted.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>
>> ---
>> docs/about/removed-features.rst | 3 ++-
>> qapi/ui.json | 12 ++++++++++++
>> ui/vnc.c | 26 ++++++++++++++++++++++++++
>> 3 files changed, 40 insertions(+), 1 deletion(-)
>>
>> diff --git a/docs/about/removed-features.rst
>> b/docs/about/removed-features.rst
>> index d42c3341de..20e6901a82 100644
>> --- a/docs/about/removed-features.rst
>> +++ b/docs/about/removed-features.rst
>> @@ -348,7 +348,8 @@ documentation of ``query-hotpluggable-cpus`` for
>> additional details.
>> ``change`` (removed in 6.0)
>> '''''''''''''''''''''''''''
>>
>> -Use ``blockdev-change-medium`` or ``change-vnc-password`` instead.
>> +Use ``blockdev-change-medium`` or ``change-vnc-password`` or
>> +``change-vnc-listen`` instead.
>>
>> ``query-events`` (removed in 6.0)
>> '''''''''''''''''''''''''''''''''
>> diff --git a/qapi/ui.json b/qapi/ui.json
>> index d7567ac866..14e6fe0b4c 100644
>> --- a/qapi/ui.json
>> +++ b/qapi/ui.json
>> @@ -1304,3 +1304,15 @@
>> { 'command': 'display-reload',
>> 'data': 'DisplayReloadOptions',
>> 'boxed' : true }
>> +
>> +##
>> +# @change-vnc-listen:
>> +#
>> +# Change set of addresses to listen for connections.
>> +#
>> +# Since: 7.0
>> +#
>> +##
>> +{ 'command': 'change-vnc-listen',
>> + 'data': { 'id': 'str', 'addresses': ['SocketAddress'],
>> + '*websockets': ['SocketAddress'] } }
>
> We already have a general purpose command above 'display-reload'
> for doing live changes to the display backends.
>
> THis should instead be
>
> { 'struct': 'DisplayReloadOptionsVNC',
> 'data': { '*tls-certs': 'bool',
> '*addresses': ['SocketAddress'],
> '*websockets': ['SocketAddress'] } }
>
> if 'addresses' is non-null then the listener can be updated.
Good point. Gerd, what do you think?
