On 12.01.22 17:50, Ilya Leoshkevich wrote: > According to PoP, both 32- and 64-bit shifts use lowest 6 address > bits. The current code special-cases 32-bit shifts to use only 5 bits, > which is not correct. For example, shifting by 32 bits currently > preserves the initial value, however, it's supposed zero it out > instead. > > Fix by merging sh32 and sh64 and adapting CC calculation to shift > values greater than 31. > > Fixes: cbe24bfa91d2 ("target-s390: Convert SHIFT, ROTATE SINGLE") > Signed-off-by: Ilya Leoshkevich <i...@linux.ibm.com> > ---
Reviewed-by: David Hildenbrand <da...@redhat.com> -- Thanks, David / dhildenb