Hi, Paolo Bonzini wrote: > > > case MODE_PAGE_R_W_ERROR: /* error recovery */ > > > [...] > > > - buf[15] = 0x00;
Kevin Wolf wrote: > > Why did you drop this? It still seems to be part of the buffer. Paolo Bonzini wrote: > Actually, I think it's best if these patches wait until Thomas can give a > shot at testing them. If that means missing 1.0, so be it. libburn does not use mode page 1 "Read/Write Error Recovery Parameters". So can only judge by theory and not by test. MMC-1 says it has 8 bytes (beginning at buf[8] = MODE_PAGE_R_W_ERROR). MMC-2 says it has 12. MMC-6 says it has 12. So buf[15] = 0x00 matches MMC-1 and the announcement made by buf[9] = 16 - 10; (6 is the number of bytes after buf[9]). I would advise to keep buf[15] = 0x00. Have a nice day :) Thomas
