Where's that commit? I think we should drop this, right?
Yes, I will submit another version without that line.
You don't need & mask32 I think. cpu_to_le32 will truncate
the value.
Makes sense, will be fixed in next version.
So it's a new API, but where's the user?
I guess just include this patch with where-ever it's actually used.
The user of virtio_pci_add_shm_cap is in the previous commits.
My original patch [0] was actually a squash of the current two commits,
but Dr. David Alan Gilbert explicitly asked me [1] to split them in
order to preserve his original virtio-pci patch [2]. I could squash
these two commits together again, but we will be back to square one [1].
[0] https://www.mail-archive.com/qemu-devel@nongnu.org/msg826814.html
[1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg826890.html
[2]
https://gitlab.freedesktop.org/virgl/qemu/-/commit/7fa847fde7143ca2ef5b0a2a13c5f669d3beb195
