On Tue, Dec 14, 2021 at 07:07:34PM +0800, huang...@chinatelecom.cn wrote:
> +void qmp_vcpu_dirty_limit(bool enable,
> + bool has_cpu_index,
> + uint64_t cpu_index,
> + bool has_dirty_rate,
> + uint64_t dirty_rate,
> + Error **errp)
> +{
> + static bool initialized;IMHO this is not needed; if we're with a global state pointer then it's the same to check against that. The rest looks mostly good (besides the last proposal on API design which you got confirmation from Markus). -- Peter Xu
