On 11/09/2011 07:56 PM, Anthony Liguori wrote: > On 11/09/2011 07:44 AM, Avi Kivity wrote: >> The fact that a host cpu supports a feature doesn't mean that QEMU >> and KVM >> will also support it, yet -cpuid host brings host features wholesale. >> >> We need to whitelist each feature separately to make sure we support it. >> This patch adds KVM whitelisting (by simply using >> KVM_GET_SUPPORTED_CPUID >> instead of the CPUID instruction). >> >> Signed-off-by: Avi Kivity<a...@redhat.com> > > This seems like a 1.0 candidate, yes?
There is a distinct possibility this will uncover bugs in kvm's KVM_GET_SUPPORTED_CPUID. Those won't be qemu bugs, so I think it's good for 1.0. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.
