On 20/12/2021 11:27, Thomas Huth wrote:
g_test_rand_int() must not be called before g_test_init(), otherwise the glib will show a "g_rand_int: assertion 'rand != NULL' failed" message in the log. So we could change the order here, but actually, g_test_rand_int() seems also the wrong choice here, since we're using it to create a temporary file name, which certainly should not depend on the "--seed" CLI option of the g_test suite. Thus let's use the g_random_int() function instead.Reported-by: Philippe Mathieu-Daudé <phi...@redhat.com> Signed-off-by: Thomas Huth <th...@redhat.com> --- tests/qtest/virtio-net-failover.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/virtio-net-failover.c b/tests/qtest/virtio-net-failover.c index 4b2ba8a106..70b94bf18f 100644 --- a/tests/qtest/virtio-net-failover.c +++ b/tests/qtest/virtio-net-failover.c @@ -1308,7 +1308,7 @@ int main(int argc, char **argv) { const gchar *tmpdir = g_get_tmp_dir(); gchar *tmpfile = g_strdup_printf("%s/failover_test_migrate-%u-%u", - tmpdir, getpid(), g_test_rand_int()); + tmpdir, getpid(), g_random_int()); int ret;g_test_init(&argc, &argv, NULL);
Reviewed-by: Laurent Vivier <lviv...@redhat.com>
