Re: [PATCH v2 03/19] ppc/pnv: Use the chip class to check the index of PHB3 devices

[Daniel Henrique Barboza]

On 12/13/21 10:28, Cédric Le Goater wrote:

The maximum number of PHB3 devices per chip can be different depending
on the POWER8 processor model.

Signed-off-by: Cédric Le Goater <c...@kaod.org>
---

Reviewed-by: Daniel Henrique Barboza <danielhb...@gmail.com>

  hw/pci-host/pnv_phb3.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/pci-host/pnv_phb3.c b/hw/pci-host/pnv_phb3.c
index 3aa42ef9d4b9..9c4451ca0d1c 100644
--- a/hw/pci-host/pnv_phb3.c
+++ b/hw/pci-host/pnv_phb3.c
@@ -993,7 +993,7 @@ static void pnv_phb3_realize(DeviceState *dev, Error **errp)
      PnvMachineState *pnv = PNV_MACHINE(qdev_get_machine());
      int i;

- if (phb->phb_id >= PNV8_CHIP_PHB3_MAX) {

+    if (phb->phb_id >= PNV_CHIP_GET_CLASS(phb->chip)->num_phbs) {
          error_setg(errp, "invalid PHB index: %d", phb->phb_id);
          return;
      }