On Tue, Dec 14, 2021 at 12:54:05AM +1100, Simon Burge wrote: > Hi Phil, > > =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= wrote: > > > Oops, missing your Signed-off-by tag, see: > > https://www.qemu.org/docs/master/devel/submitting-a-patch.html#patch-emails-must-includ > e-a-signed-off-by-line > > > > Do you mind re-sending with your S-o-b? Meanwhile, patch dropped. > > Hopefully I've configured "git format-patch" and "git send-email" > correctly and sent a better patch to the mailing list. I'll make > sure to include the maintainers in future patches.
Your v2 looks ok to me. FWIW, if you'll be sending more patches in future, it is worth giving 'git-publish' a try. It is a higher level tool around send-email and format-patch, that makes it much harder to make mistakes. It pretty much just 'does the right thing' without you needing to worry, including CC'ing the people listed in MAINTAINERS for the patch diff you have. Regards, Daniel [1] https://github.com/stefanha/git-publish -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
