To propagate errors to the caller of the pre_plug callback, use the object_poperty_set*() functions directly instead of the qdev_prop_set*() helpers.
Suggested-by: Igor Mammedov <imamm...@redhat.com> Reviewed-by: Eric Auger <eric.au...@redhat.com> Reviewed-by: Igor Mammedov <imamm...@redhat.com> Signed-off-by: Jean-Philippe Brucker <jean-phili...@linaro.org> --- hw/arm/virt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 608a0a78f0..6b51e8ad10 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -2518,8 +2518,9 @@ static void virt_machine_device_pre_plug_cb(HotplugHandler *hotplug_dev, db_start, db_end, VIRTIO_IOMMU_RESV_MEM_T_MSI); - qdev_prop_set_uint32(dev, "len-reserved-regions", 1); - qdev_prop_set_string(dev, "reserved-regions[0]", resv_prop_str); + object_property_set_uint(OBJECT(dev), "len-reserved-regions", 1, errp); + object_property_set_str(OBJECT(dev), "reserved-regions[0]", + resv_prop_str, errp); g_free(resv_prop_str); } } -- 2.34.1