On 8 November 2011 12:21, Avi Kivity <a...@redhat.com> wrote: > On 11/08/2011 02:15 PM, Peter Maydell wrote: >> This needs to be in the MemoryRegion core implementation, please. > > Right; see the memory/mutators branch. I plan to push this as soon as > everything is converted.
OK, then this save/restore patch should wait until that has landed. >> Ideally memory.c should just ensure that the memory hierarchy >> is saved and restored without devices having to do anything. > > That's a bit far-fetched - I don't want the memory core involved in > save/restore. But if/when we integrate the memory core into QOM, then > yes, that layer can take care of it. If we have an observable attribute > (that fires off a callback when changed), we can link memory API > properties into that attribute. The memory hierarchy is a visible part of the state which can change as the guest does things -- it has to get saved and restored somehow. I think it would be better done in the core where it will always be done right, rather than relying on each device to handle it correctly (especially since it's not always obvious if it's been missed out from the device.) -- PMM
