On 12/6/21 11:43, Philippe Mathieu-Daudé wrote: > On 12/6/21 10:52, Alex Bennée wrote: >> This reverts commit 7852a77f598635a67a222b6c1463c8b46098aed2. >> >> The check is bogus as it ends up finding itself and falling over. >> >> Signed-off-by: Alex Bennée <alex.ben...@linaro.org> >> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/733 >> Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> >> Message-Id: <20211202164929.1119036-1-alex.ben...@linaro.org> >> >> --- >> v2 >> - fixed bug link > > IIUC Cornelia & Mark said the correct fix is simply: > > -- >8 -- > - if (object_resolve_path_type("", TYPE_ISA_VGA, NULL)) { > + if (!object_resolve_path_type("", TYPE_ISA_VGA, NULL)) { > ---
Bah I just noticed your update on v1: https://www.mail-archive.com/qemu-devel@nongnu.org/msg854596.html So: Acked-by: Philippe Mathieu-Daudé <f4...@amsat.org> and queued to mips-fixes, thanks.
