On 12/2/21 21:48, Richard Henderson wrote:
> Replace an if ladder with a switch for clarity.
>
> Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
> ---
> target/m68k/op_helper.c | 45 +++++++++++++++++++++++++----------------
> 1 file changed, 28 insertions(+), 17 deletions(-)
> - } else if (is_hw && oldsr & SR_M &&
> - cs->exception_index >= EXCP_SPURIOUS &&
> - cs->exception_index <= EXCP_INT_LEVEL_7) {
> - do_stack_frame(env, &sp, 0, oldsr, 0, retaddr);
> - oldsr = sr;
> - env->aregs[7] = sp;
> - cpu_m68k_set_sr(env, sr &= ~SR_M);
> - sp = env->aregs[7] & ~1;
> - do_stack_frame(env, &sp, 1, oldsr, 0, retaddr);
> - } else {
> + break;
> +
> + case EXCP_SPURIOUS ... EXCP_INT_LEVEL_7:
> + if (is_hw && oldsr & SR_M) {
This is code movement, but adding parenthesis would produce
clearer code.
> + do_stack_frame(env, &sp, 0, oldsr, 0, retaddr);
> + oldsr = sr;
> + env->aregs[7] = sp;
> + cpu_m68k_set_sr(env, sr &= ~SR_M);
Similarly code movement; this assignation deserves a followup
cleanup patch...
> + sp = env->aregs[7] & ~1;
> + do_stack_frame(env, &sp, 1, oldsr, 0, retaddr);
> + break;
> + }
> + /* fall through */
> +
> + default:
> do_stack_frame(env, &sp, 0, oldsr, 0, retaddr);
> + break;
> }
Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>
