Philippe Mathieu-Daudé <phi...@redhat.com> writes: > On 11/24/21 10:29, Daniel Henrique Barboza wrote: >> The ivshmem device, as with most PCI devices, uses little endian byte >> order. However, the endianness of its mmio_ops is marked as >> DEVICE_NATIVE_ENDIAN. This presents not only the usual problems with big >> endian hosts but also with PowerPC little endian hosts as well, since >> the Power architecture in QEMU uses big endian hardware (XIVE controller, >> PCI Host Bridges, etc) even if the host is in little endian byte order. > > Maybe mention commit f7a199b2b44 ("ivshmem: use little-endian > int64_t for the protocol")?
"The protocol" is the interface between ivshmem-doorbell device (client) and ivshmem server. This commit is about the interface between ivshmem-* device and the guest. The two interfaces are about as related as SSH and DNS: software exists that uses both. Mentioning f7a199b2b44 feels superfluous to me. [...]