On 11/19/21 10:24 AM, Cédric Le Goater wrote:
+    } else if ((fpscr & FP_VXVC) && (fpscr_ve != 0)) {
+        error = POWERPC_EXCP_FP_VXVC;
+    }

Is there a defined order for these in the manual?  I couldn't find it quickly if so.  If there is no defined order, I think you should test VE only once.

Drop the use of fpscr_ve and use fpscr & FP_VE instead. (I think these hidden uses of *env are evil and should be banished, but that's a bit of a job.)

you mean all the msr_* macros ? I agree. It's huge and I wonder how we could automate parts of it.

Well, those too.  But fpscr_ve is the one that caught my eye here.


r~

Reply via email to