Hi, On 11/12/21 07:54, Song Gao wrote: > This includes: > - sockbits.h > - target_errno_defs.h > - target_fcntl.h > - termbits.h > > Signed-off-by: Song Gao <gaos...@loongson.cn> > Signed-off-by: Xiaojuan Yang <yangxiaoj...@loongson.cn> > --- > linux-user/loongarch64/sockbits.h | 1 + > linux-user/loongarch64/target_errno_defs.h | 7 +++++++ > linux-user/loongarch64/target_fcntl.h | 6 ++++++ > linux-user/loongarch64/termbits.h | 1 + > 4 files changed, 15 insertions(+) > create mode 100644 linux-user/loongarch64/sockbits.h > create mode 100644 linux-user/loongarch64/target_errno_defs.h > create mode 100644 linux-user/loongarch64/target_fcntl.h > create mode 100644 linux-user/loongarch64/termbits.h > > diff --git a/linux-user/loongarch64/sockbits.h > b/linux-user/loongarch64/sockbits.h > new file mode 100644 > index 0000000..0e4c8f0 > --- /dev/null > +++ b/linux-user/loongarch64/sockbits.h > @@ -0,0 +1 @@
Why not guarding the header here, ... > +#include "../generic/sockbits.h" > diff --git a/linux-user/loongarch64/target_errno_defs.h > b/linux-user/loongarch64/target_errno_defs.h > new file mode 100644 > index 0000000..17165c1 > --- /dev/null > +++ b/linux-user/loongarch64/target_errno_defs.h > @@ -0,0 +1,7 @@ > +#ifndef LOONGARCH_TARGET_ERRNO_DEFS_H > +#define LOONGARCH_TARGET_ERRNO_DEFS_H ... but guard this one? > + > +/* Target uses generic errno */ > +#include "../generic/target_errno_defs.h" > + > +#endif New files require a license. I'd recommend adding a SPDX tag in the first line. For example with GPLv2+: /* SPDX-License-Identifier: GPL-2.0-or-later */
