On Fri, 4 Nov 2011 14:03:47 +0000
Stefan Hajnoczi <stefa...@gmail.com> wrote:
> On Thu, Nov 3, 2011 at 6:36 PM, Luiz Capitulino <lcapitul...@redhat.com>
> wrote:
> > +Here's the implementation of the 'hello-world' HMP command:
> > +
> > +void hmp_hello_world(Monitor *mon, const QDict *qdict)
> > +{
> > + Error *errp = NULL;
> > + const char *message = qdict_get_str(qdict, "message");
>
> Since message is optional this should be qdict_get_try_str().
Good catch. That was my first version (and I did get an abort() there),
but forgot to fix it in the doc.
Thanks.
