On Fri, Nov 05, 2021 at 12:48:17AM +0800, Cindy Lu wrote: > these patches add the support for configure interrupt > > These codes are all tested in vp-vdpa (support configure interrupt) > vdpa_sim (not support configure interrupt), virtio tap device > > test in virtio-pci bus and virtio-mmio bus
Hi, vhost-user has a configuration space change notification but it uses a slave channel message (VHOST_USER_SLAVE_CONFIG_CHANGE_MSG) instead of an eventfd. Ideally the vhost kernel ioctl and vhost-user interfaces would follow the same design. I'm concerned "common" vhost code is going to end up with lots of callbacks that are not available uniformly across vhost kernel, vdpa, and vhost-user. That makes it hard to understand and debug vhost, plus differences make it harder to to correctly extend these interfaces in the future. Is the decision to a new eventfd-based interface instead of vhost_chr_read/write() deliberate? If yes, do you think VHOST_USER_SLAVE_CONFIG_CHANGE_MSG was a design mistake in vhost-user that needs to be fixed? Stefan
signature.asc
Description: PGP signature
