On Thu, Nov 03, 2011 at 01:51:54PM -0200, Luiz Capitulino wrote: > On Tue, 1 Nov 2011 18:08:16 +0000 > Stefan Hajnoczi <stefa...@linux.vnet.ibm.com> wrote: > > > Move from plain HMP/QMP command implementation to QAPI. The > > block_stream command takes arguments, returns nothing, may raise errors, > > and will raise a QMP event when the operation completes. > > --- > > Hi Luiz, > > I converted block_stream to QAPI. The in-tree examples are quite simple so > > far > > so I hope I've converted this command in a reasonable way. Please let me > > know > > what you think: > > In general it looks good. The fact that the diff is against your latest series > (vs. against master) didn't help me, so I couldn't test the command.
Thanks for the feedback. I will send out proper patches for all image streaming commands soon. Just wanted to make sure I'm using doing the QAPI conversion correctly before I do all of the commands. Stefan
